Closed
Conversation
Contributor
|
Few things.
This easily conflicts among multiple builds. Can you update this to use uuid?
|
2424525 to
202d1cb
Compare
busunkim96
commented
May 11, 2020
Contributor
Contributor
|
@sirtorry I did a quick search for the region tag, and there are still used in multiple location. Although they're all translated page, can we really delete them now? |
Contributor
|
I'm going to submit a request for these samples to be replaced on our localised/non-english documentation. We shouldn't remove the samples until that's been done. In this case, should we re-enable these tests? |
Contributor
Author
Contributor
|
@busunkim96 Yes, it's alright! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3706.
I don't have the context around why these tests were disabled. Does these tests need to be modified in some other way?
#1608 disabled these tests.